me
/
guix
Archived
1
0
Fork 0
Code

lint: Warn about single-character package names. 

A common-sense exception is made for R.

* guix/lint.scm (check-name): New procedure.
(%local-checkers): Add it.
master
Tobias Geerinckx-Rice via Bug reports for GNU Guix 2021-03-09 22:41:58 +01:00 committed by Tobias Geerinckx-Rice
parent 1b1a61f86a
commit 1126bb9cf3
No known key found for this signature in database
GPG Key ID: 0DB0FF884F556D79
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
guix/lint.scm
View File

@ -6,7 +6,7 @@
;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org> ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com> ;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2017 Alex Kost <alezost@gmail.com> ;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr> ;;; Copyright © 2017, 2021 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2017, 2018, 2020 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2017, 2018, 2020 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net> ;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2020 Chris Marusich <cmmarusich@gmail.com> ;;; Copyright © 2020 Chris Marusich <cmmarusich@gmail.com>
@ -170,6 +170,18 @@
(requires-store? lint-checker-requires-store? (requires-store? lint-checker-requires-store?
(default #f))) (default #f)))
(define (check-name package)
"Check whether PACKAGE's name matches our guidelines."
(let ((name (package-name package)))
;; Currently checks only whether the name is too short.
(if (and (<= (string-length name) 1)
(not (string=? name "r"))) ; common-sense exception
(list
(make-warning package
(G_ "name should be longer than a single character")
#:field 'name))
'())))
(define (properly-starts-sentence? s) (define (properly-starts-sentence? s)
(string-match "^[(\"'`[:upper:][:digit:]]" s)) (string-match "^[(\"'`[:upper:][:digit:]]" s))
@ -1446,6 +1458,10 @@ them for PACKAGE."
(define %local-checkers (define %local-checkers
(list (list
(lint-checker
(name 'name)
(description "Validate package names")
(check check-name))
(lint-checker (lint-checker
(name 'description) (name 'description)
(description "Validate package descriptions") (description "Validate package descriptions")