me/guix
Archived
1
0
Fork 0
Code Activity

gnu: mcrypt: Fix patches for CVE-2012-{4409,4527}.

Browse source 
This fixes CVE-2012-{4409,4527}.

This is a followup to commit fd1461879c.

* gnu/packages/patches/mcrypt-CVE-2012-4409.patch,
gnu/packages/patches/mcrypt-CVE-2012-4527.patch: Apply the patches to the mcrypt
source code.
This commit is contained in:
Leo Famulari 2017-01-04 02:37:51 -05:00
parent 37e8a2e219
commit 324f4fc559
No known key found for this signature in database
GPG key ID: 2646FA30BACA7F08
2 changed files with 104 additions and 129 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
gnu/packages/patches/mcrypt-CVE-2012-4409.patch
View file

@ -3,30 +3,17 @@ From: Tom Callaway <spot@fedoraproject.org>
Date: Fri, 7 Sep 2012 11:39:29 -0400 Date: Fri, 7 Sep 2012 11:39:29 -0400
Subject: apply fix for CVE-2012-4409 (thanks to Raphael Geissert) Subject: apply fix for CVE-2012-4409 (thanks to Raphael Geissert)
--- --- mcrypt-2.6.8/src/extra.c.CVE-2012-4409 2012-09-07 11:00:55.906870746 -0400
mcrypt-CVE-2012-4409.patch | 12 ++++++++++++ +++ mcrypt-2.6.8/src/extra.c 2012-09-07 11:00:27.967858365 -0400
mcrypt.spec | 10 +++++++++- @@ -242,6 +242,8 @@ int check_file_head(FILE * fstream, char
2 files changed, 21 insertions(+), 1 deletion(-) if (m_getbit(0, sflag) != 0) { /* if the first bit is set */
create mode 100644 mcrypt-CVE-2012-4409.patch *salt_size = m_setbit(0, sflag, 0);
if (*salt_size > 0) {
diff --git a/mcrypt-CVE-2012-4409.patch b/mcrypt-CVE-2012-4409.patch + if (*salt_size > sizeof(tmp_buf))
new file mode 100644 + err_quit(_("Salt is too long\n"));
index 0000000..747f428 fread(tmp_buf, 1, *salt_size,
--- /dev/null fstream);
+++ b/mcrypt-CVE-2012-4409.patch memmove(salt, tmp_buf, *salt_size);
@@ -0,0 +1,12 @@
+diff -up mcrypt-2.6.8/src/extra.c.CVE-2012-4409 mcrypt-2.6.8/src/extra.c
+--- mcrypt-2.6.8/src/extra.c.CVE-2012-4409 2012-09-07 11:00:55.906870746 -0400
++++ mcrypt-2.6.8/src/extra.c 2012-09-07 11:00:27.967858365 -0400
+@@ -242,6 +242,8 @@ int check_file_head(FILE * fstream, char
+ if (m_getbit(0, sflag) != 0) { /* if the first bit is set */
+ *salt_size = m_setbit(0, sflag, 0);
+ if (*salt_size > 0) {
++ if (*salt_size > sizeof(tmp_buf))
++ err_quit(_("Salt is too long\n"));
+ fread(tmp_buf, 1, *salt_size,
+ fstream);
+ memmove(salt, tmp_buf, *salt_size);
-- --
cgit v0.12 cgit v0.12

194
gnu/packages/patches/mcrypt-CVE-2012-4527.patch
View file

@ -3,109 +3,97 @@ From: Tom Callaway <spot@fedoraproject.org>
Date: Tue, 30 Oct 2012 15:39:24 -0400 Date: Tue, 30 Oct 2012 15:39:24 -0400
Subject: apply workaround to CVE-2012-4527 Subject: apply workaround to CVE-2012-4527
--- --- mcrypt-2.6.8.orig/src/mcrypt.c
mcrypt-CVE-2012-4527-80-width-patch | 91 +++++++++++++++++++++++++++++++++++++ +++ mcrypt-2.6.8/src/mcrypt.c
mcrypt.spec | 10 +++- @@ -41,6 +41,8 @@
2 files changed, 100 insertions(+), 1 deletion(-) # include <time.h>
create mode 100644 mcrypt-CVE-2012-4527-80-width-patch #endif
diff --git a/mcrypt-CVE-2012-4527-80-width-patch b/mcrypt-CVE-2012-4527-80-width-patch +#define WIDTH 80
new file mode 100644
index 0000000..0eb94d8
--- /dev/null
+++ b/mcrypt-CVE-2012-4527-80-width-patch
@@ -0,0 +1,91 @@
+--- mcrypt-2.6.8.orig/src/mcrypt.c
++++ mcrypt-2.6.8/src/mcrypt.c
+@@ -41,6 +41,8 @@
+ # include <time.h>
+ #endif
+ +
++#define WIDTH 80 static char rcsid[] =
++ "$Id: mcrypt.c,v 1.2 2007/11/07 17:10:21 nmav Exp $";
+ static char rcsid[] =
+ "$Id: mcrypt.c,v 1.2 2007/11/07 17:10:21 nmav Exp $"; @@ -482,7 +484,7 @@
+ #ifdef HAVE_STAT
+@@ -482,7 +484,7 @@ if (stream_flag == FALSE) {
+ #ifdef HAVE_STAT if (is_normal_file(file[i]) == FALSE) {
+ if (stream_flag == FALSE) { - sprintf(tmperr,
+ if (is_normal_file(file[i]) == FALSE) { + snprintf(tmperr, WIDTH,
+- sprintf(tmperr, _
++ snprintf(tmperr, WIDTH, ("%s: %s is not a regular file. Skipping...\n"),
+ _ program_name, file[i]);
+ ("%s: %s is not a regular file. Skipping...\n"), @@ -501,7 +503,7 @@
+ program_name, file[i]); dinfile = file[i];
+@@ -501,7 +503,7 @@ if ((isatty(fileno((FILE *) (stdin))) == 1)
+ dinfile = file[i]; && (stream_flag == TRUE) && (force == 0)) { /* not a tty */
+ if ((isatty(fileno((FILE *) (stdin))) == 1) - sprintf(tmperr,
+ && (stream_flag == TRUE) && (force == 0)) { /* not a tty */ + snprintf(tmperr, WIDTH,
+- sprintf(tmperr, _
++ snprintf(tmperr, WIDTH, ("%s: Encrypted data will not be read from a terminal.\n"),
+ _ program_name);
+ ("%s: Encrypted data will not be read from a terminal.\n"), @@ -520,7 +522,7 @@
+ program_name); einfile = file[i];
+@@ -520,7 +522,7 @@ if ((isatty(fileno((FILE *) (stdout))) == 1)
+ einfile = file[i]; && (stream_flag == TRUE) && (force == 0)) { /* not a tty */
+ if ((isatty(fileno((FILE *) (stdout))) == 1) - sprintf(tmperr,
+ && (stream_flag == TRUE) && (force == 0)) { /* not a tty */ + snprintf(tmperr, WIDTH,
+- sprintf(tmperr, _
++ snprintf(tmperr, WIDTH, ("%s: Encrypted data will not be written to a terminal.\n"),
+ _ program_name);
+ ("%s: Encrypted data will not be written to a terminal.\n"), @@ -544,7 +546,7 @@
+ program_name); strcpy(outfile, einfile);
+@@ -544,7 +546,7 @@ /* if file has already the .nc ignore it */
+ strcpy(outfile, einfile); if (strstr(outfile, ".nc") != NULL) {
+ /* if file has already the .nc ignore it */ - sprintf(tmperr,
+ if (strstr(outfile, ".nc") != NULL) { + snprintf(tmperr, WIDTH,
+- sprintf(tmperr, _
++ snprintf(tmperr, WIDTH, ("%s: file %s has the .nc suffix... skipping...\n"),
+ _ program_name, outfile);
+ ("%s: file %s has the .nc suffix... skipping...\n"), @@ -590,10 +592,10 @@
+ program_name, outfile);
+@@ -590,10 +592,10 @@ if (x == 0) {
+ if (stream_flag == FALSE) {
+ if (x == 0) { - sprintf(tmperr, _("File %s was decrypted.\n"), dinfile);
+ if (stream_flag == FALSE) { + snprintf(tmperr, WIDTH, _("File %s was decrypted.\n"), dinfile);
+- sprintf(tmperr, _("File %s was decrypted.\n"), dinfile); err_warn(tmperr);
++ snprintf(tmperr, WIDTH, _("File %s was decrypted.\n"), dinfile); } else {
+ err_warn(tmperr); - sprintf(tmperr, _("Stdin was decrypted.\n"));
+ } else { + snprintf(tmperr, WIDTH, _("Stdin was decrypted.\n"));
+- sprintf(tmperr, _("Stdin was decrypted.\n")); err_warn(tmperr);
++ snprintf(tmperr, WIDTH, _("Stdin was decrypted.\n")); }
+ err_warn(tmperr); #ifdef HAVE_STAT
+ } @@ -610,7 +612,7 @@
+ #ifdef HAVE_STAT
+@@ -610,7 +612,7 @@ } else {
+ if (stream_flag == FALSE) {
+ } else { - sprintf(tmperr,
+ if (stream_flag == FALSE) { + snprintf(tmperr, WIDTH,
+- sprintf(tmperr, _
++ snprintf(tmperr, WIDTH, ("File %s was NOT decrypted successfully.\n"),
+ _ dinfile);
+ ("File %s was NOT decrypted successfully.\n"), @@ -636,10 +638,10 @@
+ dinfile);
+@@ -636,10 +638,10 @@ if (x == 0) {
+ if (stream_flag == FALSE) {
+ if (x == 0) { - sprintf(tmperr, _("File %s was encrypted.\n"), einfile);
+ if (stream_flag == FALSE) { + snprintf(tmperr, WIDTH, _("File %s was encrypted.\n"), einfile);
+- sprintf(tmperr, _("File %s was encrypted.\n"), einfile); err_warn(tmperr);
++ snprintf(tmperr, WIDTH, _("File %s was encrypted.\n"), einfile); } else {
+ err_warn(tmperr); - sprintf(tmperr, _("Stdin was encrypted.\n"));
+ } else { + snprintf(tmperr, WIDTH, _("Stdin was encrypted.\n"));
+- sprintf(tmperr, _("Stdin was encrypted.\n")); err_warn(tmperr);
++ snprintf(tmperr, WIDTH, _("Stdin was encrypted.\n")); }
+ err_warn(tmperr); #ifdef HAVE_STAT
+ } @@ -655,7 +657,7 @@
+ #ifdef HAVE_STAT
+@@ -655,7 +657,7 @@ } else {
+ if (stream_flag == FALSE) {
+ } else { - sprintf(tmperr,
+ if (stream_flag == FALSE) { + snprintf(tmperr, WIDTH,
+- sprintf(tmperr, _
++ snprintf(tmperr, WIDTH, ("File %s was NOT encrypted successfully.\n"),
+ _ einfile);
+ ("File %s was NOT encrypted successfully.\n"), -
+ einfile); git v0.12
--
cgit v0.12