me
/
guix
Archived
1
0
Fork 0
Code

import: github: Use HTTP "Authorization" header for access tokens. 

Fixes <https://bugs.gnu.org/39511>.

The "access_token" query parameter is now deprecated:

  https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

* guix/import/github.scm (fetch-releases-or-tags)[headers]: Add
"Authorization" header when (%github-token) is true.
[decorate]: Remove, and remove callers.
master
Matt Wette 2020-02-22 11:48:29 +01:00 committed by Ludovic Courtès
parent eb85995738
commit 3d1e42321f
No known key found for this signature in database
GPG Key ID: 090B11993D9AEBB5
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
guix/import/github.scm
View File

@ -154,18 +154,16 @@ empty list."
;; Ask for version 3 of the API as suggested at ;; Ask for version 3 of the API as suggested at
;; <https://developer.github.com/v3/>. ;; <https://developer.github.com/v3/>.
`((Accept . "application/vnd.github.v3+json") `((Accept . "application/vnd.github.v3+json")
(user-agent . "GNU Guile"))) (user-agent . "GNU Guile")
,@(if (%github-token)
`((Authorization . ,(string-append "token " (%github-token))))
'())))
(define (decorate url) (match (json-fetch release-url #:headers headers)
(if (%github-token)
(string-append url "?access_token=" (%github-token))
url))
(match (json-fetch (decorate release-url) #:headers headers)
(#() (#()
;; We got the empty list, presumably because the user didn't use GitHub's ;; We got the empty list, presumably because the user didn't use GitHub's
;; "release" mechanism, but hopefully they did use Git tags. ;; "release" mechanism, but hopefully they did use Git tags.
(json-fetch (decorate tag-url) #:headers headers)) (json-fetch tag-url #:headers headers))
(x x))) (x x)))
(define (latest-released-version url package-name) (define (latest-released-version url package-name)