gnu: libnatpmp: Update to 20230423-0.6a850fd.

* gnu/packages/networking.scm (libnatpmp): Update to 20230423-0.6a850fd.
[source]: Fetch from git.
[build-system]: Use cmake-build-system.
[arguments]: Add patch-build-system and fix-version phases.  Reinstate
configure and check phase, but set #:tests? to #f.  New #:configure-flags
argument.
[native-inputs]: Add which.

gnu/packages/networking.scm

@@ -1414,33 +1414,50 @@ files contain direct mappings of the abstractions provided by the ØMQ C API.")
     (license license:expat)))
 
 (define-public libnatpmp
+  ;; Install the latest commit as it provides a pkg-config (.pc) file.
+  (let ((base-version "20230423")
+        (commit "6a850fd2bd9b08e6edc886382a1dbae2a7df55ec")
+        (revision "0"))
     (package
       (name "libnatpmp")
-    (version "20230423")
+      (version (git-version base-version revision commit))
       (source (origin
-              (method url-fetch)
+                (method git-fetch)
-              (uri (string-append
+                (uri (git-reference
-                    "http://miniupnp.free.fr/files/"
+                      (url "https://github.com/miniupnp/libnatpmp")
-                    name "-" version ".tar.gz"))
+                      (commit commit)))
+                (file-name (git-file-name name version))
                 (sha256
                  (base32
-                "0w7wvf4yi8qv659dg9d3ndqvh3bqhgm21gd135spwhq6hhnfv106"))))
+                  "18hf9a3i3mncl3w80nzi1684iac3by86bv0hgmbm1v2w8gbfjyw0"))))
-    (build-system gnu-build-system)
+      (build-system cmake-build-system)
       (arguments
-     (list #:phases #~(modify-phases %standard-phases
+       (list
-                        (delete 'configure)
+        #:tests? #f                     ;no test suite
-                        (delete 'check)) ; no tests
+        #:configure-flags #~(list "-DBUILD_SHARED_LIBS=ON")
-           #:make-flags
+        #:phases
-           #~(list (string-append "CC=" #$(cc-for-target))
+        #~(modify-phases %standard-phases
-                   (string-append "INSTALLPREFIX=" #$output)
+            (add-after 'unpack 'patch-build-system
-                   (string-append "LDFLAGS=-Wl,-rpath=" #$output "/lib"))))
+              ;; Have CMake install the natpmp_declspec.h missing header file
+              ;; that is referenced by natpmp.h (see:
+              ;; https://github.com/miniupnp/libnatpmp/issues/41).
+              (lambda _
+                (substitute* "CMakeLists.txt"
+                  (("install\\(FILES natpmp.h")
+                   "install(FILES natpmp.h natpmp_declspec.h"))))
+            (add-after 'unpack 'fix-version
+              (lambda _
+                (with-output-to-file "VERSION"
+                  (lambda ()
+                    (display #$base-version))))))))
+      (native-inputs (list which))
       (home-page "https://miniupnp.tuxfamily.org/libnatpmp.html")
       (synopsis "C library implementing NAT-PMP")
       (description
        "@code{libnatpmp} is a portable and asynchronous implementation of
 the Network Address Translation - Port Mapping Protocol (NAT-PMP)
 written in the C programming language.")
-    (license license:bsd-3)))
+      (license license:bsd-3))))
 
 (define-public librdkafka
   (package