me/guix
Archived
1
0
Fork 0
Code Activity

gnu: glib: Actually skip tests that fail on i686.

Browse source 
* gnu/packages/glib.scm (glib)[arguments]: In 'disable-failing-tests'
phase, when 'target-x86-32?' returns true, skip several tests in
timer.c.
This commit is contained in:
Ludovic Courtès 2021-09-22 16:37:04 +02:00
parent d58e52b071
commit 5b674fe5c3
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gnu/packages/glib.scm
View file

@ -232,16 +232,15 @@ shared NFS home directories.")
"gdbus-peer.c" "appinfo.c" "desktop-app-info.c") "gdbus-peer.c" "appinfo.c" "desktop-app-info.c")
(("[ \t]*g_test_add_func.*;") ""))) (("[ \t]*g_test_add_func.*;") "")))
,@(if (let ((system (or (%current-target-system) ,@(if (target-x86-32?)
(%current-system)))) ;; Comment out parts of timer.c that fail on i686 due to
(or (string-prefix? "i686-" system) ;; excess precision when building with GCC 10:
(string-prefix? "i586-" system)))
;; Add the 'volatile' qualifier for doubles to avoid excess
;; precision, which leads to test failures:
;; <https://gitlab.gnome.org/GNOME/glib/-/issues/820>. ;; <https://gitlab.gnome.org/GNOME/glib/-/issues/820>.
'((substitute* "glib/tests/timer.c" '((substitute* "glib/tests/timer.c"
(("gdouble elapsed") (("^ g_assert_cmpuint \\(micros.*" all)
"volatile gdouble elapsed"))) (string-append "//" all "\n"))
(("^ g_assert_cmpfloat \\(elapsed, ==.*" all)
(string-append "//" all "\n"))))
'()) '())
#t)) #t))
;; Python references are not being patched in patch-phase of build, ;; Python references are not being patched in patch-phase of build,