me/guix
Archived
1
0
Fork 0
Code Activity

channels: Warn about missing introductions.

Browse source 
* guix/channels.scm (latest-channel-instance): Warn when CHANNEL has no
introduction and CHECKOUT contains '.guix-authorizations'.
This commit is contained in:
Ludovic Courtès 2022-10-04 09:28:01 +02:00
parent ae1af5d787
commit 5bc4b8e8e3
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
1 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
guix/channels.scm
View file

@ -419,6 +419,15 @@ their relation. When AUTHENTICATE? is false, CHANNEL is not authenticated."
(if authenticate? (if authenticate?
(if (channel-introduction channel) (if (channel-introduction channel)
(authenticate-channel channel checkout commit) (authenticate-channel channel checkout commit)
(begin
(when (file-exists?
(string-append checkout "/.guix-authorizations"))
(warning (and=> (channel-location channel)
source-properties->location)
(G_ "channel '~a' lacks 'introduction' field but \
'.guix-authorizations' found\n")
(channel-name channel)))
;; TODO: Warn for all the channels once the authentication interface ;; TODO: Warn for all the channels once the authentication interface
;; is public. ;; is public.
(when (guix-channel? channel) (when (guix-channel? channel)
@ -431,7 +440,7 @@ introduction and cannot be authenticated~%")
(hint (G_ "Add the missing introduction to your (hint (G_ "Add the missing introduction to your
channels file to address the issue. Alternatively, you can pass channels file to address the issue. Alternatively, you can pass
@option{--disable-authentication}, at the risk of running unauthenticated and @option{--disable-authentication}, at the risk of running unauthenticated and
thus potentially malicious code.")))))))) thus potentially malicious code.")))))))))
(warning (G_ "channel authentication disabled~%"))) (warning (G_ "channel authentication disabled~%")))
(when (guix-channel? channel) (when (guix-channel? channel)