me
/
guix
Archived
1
0
Fork 0
Code

deprecation: Refine the old daemon deprecation warning message. 

* guix/deprecation.scm (warn-about-old-daemon): Mention a direct consequence
of failing to upgrade the daemon.
* guix/store.scm (build-things): Add a comment explaining the rationale to
emit a deprecation warning for a daemon older than version 0x163.

Suggested-by: Ricardo Wurmus <rekado@elephly.net>
master
Maxim Cournoyer 2022-02-08 21:01:04 -05:00
parent 84b41d2dfe
commit 96d7535b03
No known key found for this signature in database
GPG Key ID: 1260E46482E63562
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
guix/deprecation.scm
View File

@ -36,8 +36,9 @@
;;; Code: ;;; Code:
(define (warn-about-old-daemon) (define (warn-about-old-daemon)
(warning (G_ "Your Guix daemon is seriously outdated, please consider (warning (G_ "Your Guix daemon is severely outdated, and will soon cease to
updating it by following the 'Upgrading Guix' documentation section.~%"))) be able to download binary substitutes. To upgrade it, refer to the
'Upgrading Guix' section in the manual.~%")))
(define* (warn-about-deprecation variable properties (define* (warn-about-deprecation variable properties
#:key replacement) #:key replacement)

6
guix/store.scm
View File

@ -1442,7 +1442,11 @@ When a handler is installed with 'with-build-handler', it is called any time
things))) things)))
(parameterize ((current-store-protocol-version (parameterize ((current-store-protocol-version
(store-connection-version store))) (store-connection-version store)))
(when (< (current-store-protocol-version) 355) ;0x163 (when (< (current-store-protocol-version) #x163)
;; This corresponds to the first version bump of the daemon
;; since the introduction of lzip compression support. The
;; version change happened with commit 6ef61cc4c30 on the
;; 2018/10/15).
(warn-about-old-daemon)) (warn-about-old-daemon))
(if (>= (store-connection-minor-version store) 15) (if (>= (store-connection-minor-version store) 15)
(build store things mode) (build store things mode)