me
/
guix
Archived
1
0
Fork 0

build: Add a Guile custom test driver using SRFI-64.

Before that '.log' files for scheme tests were fragmented and not
included in test-suite.log.  This unifies the semantics of SRFI-64 API
with Automake test suite.

* build-aux/test-driver.scm: New file.
* Makefile.am (SCM_LOG_DRIVER, AM_SCM_LOG_DRIVER_FLAGS): New variables.
(SCM_LOG_COMPILER, AM_SCM_LOG_FLAGS): Delete variables.
(AM_TESTS_ENVIRONMENT): Set GUILE_AUTO_COMPILE to 0.
* test-env.in: Silence guix-daemon.
* doc/guix.texi (Running the Test Suite): Describe how to display the
detailed results.  Bug reports require only 'test-suite.log' file.
* tests/base32.scm, tests/build-utils.scm, tests/builders.scm,
tests/challenge.scm, tests/cpan.scm, tests/cpio.scm, tests/cran.scm,
tests/cve.scm, tests/derivations.scm, tests/elpa.scm,
tests/file-systems.scm, tests/gem.scm, tests/gexp.scm,
tests/gnu-maintenance.scm, tests/grafts.scm, tests/graph.scm,
tests/gremlin.scm, tests/hackage.scm, tests/hash.scm,
tests/import-utils.scm, tests/lint.scm, tests/monads.scm, tests/nar.scm,
tests/packages.scm, tests/pk-crypto.scm, tests/pki.scm,
tests/profiles.scm, tests/publish.scm, tests/pypi.scm,
tests/records.scm, tests/scripts-build.scm, tests/scripts.scm,
tests/services.scm, tests/sets.scm, tests/size.scm, tests/snix.scm,
tests/store.scm, tests/substitute.scm, tests/syscalls.scm,
tests/system.scm, tests/ui.scm, tests/union.scm, tests/upstream.scm,
tests/utils.scm: Don't exit at the end of test groups.
* tests/containers.scm: Likewise.  Use 'test-skip' instead of exiting
with error code 77.
master
Mathieu Lirzin 2015-10-26 23:47:24 +01:00
parent e25f017422
commit a9edb211e7
49 changed files with 211 additions and 146 deletions

View File

@ -293,10 +293,11 @@ endif BUILD_DAEMON
TESTS = $(SCM_TESTS) $(SH_TESTS) TESTS = $(SCM_TESTS) $(SH_TESTS)
AM_TESTS_ENVIRONMENT = abs_top_srcdir="$(abs_top_srcdir)" AM_TESTS_ENVIRONMENT = abs_top_srcdir="$(abs_top_srcdir)" GUILE_AUTO_COMPILE=0
SCM_LOG_COMPILER = $(top_builddir)/test-env $(GUILE) SCM_LOG_DRIVER = $(top_builddir)/test-env $(GUILE) --no-auto-compile \
AM_SCM_LOG_FLAGS = --no-auto-compile -L "$(top_srcdir)" -e main $(top_srcdir)/build-aux/test-driver.scm
AM_SCM_LOG_DRIVER_FLAGS = --brief=yes
SH_LOG_COMPILER = $(top_builddir)/test-env $(SHELL) SH_LOG_COMPILER = $(top_builddir)/test-env $(SHELL)
AM_SH_LOG_FLAGS = -x -e AM_SH_LOG_FLAGS = -x -e

View File

@ -0,0 +1,189 @@
;;;; test-driver.scm - Guile test driver for Automake testsuite harness
(define script-version "2016-04-03.12") ;UTC
;;; Copyright © 2015, 2016 Mathieu Lirzin <mthl@gnu.org>
;;;
;;; This program is free software; you can redistribute it and/or modify it
;;; under the terms of the GNU General Public License as published by
;;; the Free Software Foundation; either version 3 of the License, or (at
;;; your option) any later version.
;;;
;;; This program is distributed in the hope that it will be useful, but
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;;; GNU General Public License for more details.
;;;
;;; You should have received a copy of the GNU General Public License
;;; along with this program. If not, see <http://www.gnu.org/licenses/>.
;;;; Commentary:
;;;
;;; This script provides a Guile test driver using the SRFI-64 Scheme API for
;;; test suites. SRFI-64 is distributed with Guile since version 2.0.9.
;;;
;;;; Code:
(use-modules (ice-9 getopt-long)
(ice-9 pretty-print)
(srfi srfi-26)
(srfi srfi-64))
(define (show-help)
(display "Usage:
test-driver --test-name=NAME --log-file=PATH --trs-file=PATH
[--expect-failure={yes|no}] [--color-tests={yes|no}]
[--enable-hard-errors={yes|no}] [--brief={yes|no}}] [--]
TEST-SCRIPT [TEST-SCRIPT-ARGUMENTS]
The '--test-name', '--log-file' and '--trs-file' options are mandatory.\n"))
(define %options
'((test-name (value #t))
(log-file (value #t))
(trs-file (value #t))
(color-tests (value #t))
(expect-failure (value #t)) ;XXX: not implemented yet
(enable-hard-errors (value #t)) ;not implemented in SRFI-64
(brief (value #t))
(help (single-char #\h) (value #f))
(version (single-char #\V) (value #f))))
(define (option->boolean options key)
"Return #t if the value associated with KEY in OPTIONS is \"yes\"."
(and=> (option-ref options key #f) (cut string=? <> "yes")))
(define* (test-display field value #:optional (port (current-output-port))
#:key pretty?)
"Display \"FIELD: VALUE\\n\" on PORT."
(if pretty?
(begin
(format port "~A:~%" field)
(pretty-print value port #:per-line-prefix "+ "))
(format port "~A: ~A~%" field value)))
(define* (result->string symbol #:key colorize?)
"Return SYMBOL as an upper case string. Use colors when COLORIZE is #t."
(let ((result (string-upcase (symbol->string symbol))))
(if colorize?
(string-append (case symbol
((pass) "") ;green
((xfail) "") ;light green
((skip) "") ;blue
((fail xpass) "") ;red
((error) "")) ;magenta
result
"") ;no color
result)))
(define* (test-runner-gnu test-name #:key color? brief? out-port trs-port)
"Return an custom SRFI-64 test runner. TEST-NAME is a string specifying the
file name of the current the test. COLOR? specifies whether to use colors,
and BRIEF?, well, you know. OUT-PORT and TRS-PORT must be output ports. The
current output port is supposed to be redirected to a '.log' file."
(define (test-on-test-begin-gnu runner)
;; Procedure called at the start of an individual test case, before the
;; test expression (and expected value) are evaluated.
(let ((result (cute assq-ref (test-result-alist runner) <>)))
(test-display "test-name" (result 'test-name))
(test-display "location"
(string-append (result 'source-file) ":"
(number->string (result 'source-line))))
(test-display "source" (result 'source-form) #:pretty? #t)))
(define (test-on-test-end-gnu runner)
;; Procedure called at the end of an individual test case, when the result
;; of the test is available.
(let* ((results (test-result-alist runner))
(result? (cut assq <> results))
(result (cut assq-ref results <>)))
(unless brief?
;; Display the result of each test case on the console.
(test-display
(result->string (test-result-kind runner) #:colorize? color?)
(string-append test-name " - " (test-runner-test-name runner))
out-port))
(when (result? 'expected-value)
(test-display "expected-value" (result 'expected-value)))
(when (result? 'expected-error)
(test-display "expected-error" (result 'expected-error) #:pretty? #t))
(when (result? 'actual-value)
(test-display "actual-value" (result 'actual-value)))
(when (result? 'actual-error)
(test-display "actual-error" (result 'actual-error) #:pretty? #t))
(test-display "result" (result->string (result 'result-kind)))
(newline)
(test-display ":test-result"
(string-append (result->string (test-result-kind runner))
" " (test-runner-test-name runner))
trs-port)))
(define (test-on-group-end-gnu runner)
;; Procedure called by a 'test-end', including at the end of a test-group.
(let ((fail (or (positive? (test-runner-fail-count runner))
(positive? (test-runner-xpass-count runner))))
(skip (or (positive? (test-runner-skip-count runner))
(positive? (test-runner-xfail-count runner)))))
;; XXX: The global results need some refinements for XPASS.
(test-display ":global-test-result"
(if fail "FAIL" (if skip "SKIP" "PASS"))
trs-port)
(test-display ":recheck"
(if fail "yes" "no")
trs-port)
(test-display ":copy-in-global-log"
(if (or fail skip) "yes" "no")
trs-port)
(when brief?
;; Display the global test group result on the console.
(test-display (result->string (if fail 'fail (if skip 'skip 'pass))
#:colorize? color?)
test-name
out-port))
#f))
(let ((runner (test-runner-null)))
(test-runner-on-test-begin! runner test-on-test-begin-gnu)
(test-runner-on-test-end! runner test-on-test-end-gnu)
(test-runner-on-group-end! runner test-on-group-end-gnu)
(test-runner-on-bad-end-name! runner test-on-bad-end-name-simple)
runner))
;;;
;;; Entry point.
;;;
(define (main . args)
(let* ((opts (getopt-long (command-line) %options))
(option (cut option-ref opts <> <>)))
(cond
((option 'help #f) (show-help))
((option 'version #f) (format #t "test-driver.scm ~A" script-version))
(else
(let ((log (open-file (option 'log-file "") "w0"))
(trs (open-file (option 'trs-file "") "wl"))
(out (duplicate-port (current-output-port) "wl")))
(redirect-port log (current-output-port))
(redirect-port log (current-warning-port))
(redirect-port log (current-error-port))
(test-with-runner
(test-runner-gnu (option 'test-name #f)
#:color? (option->boolean opts 'color-tests)
#:brief? (option->boolean opts 'brief)
#:out-port out #:trs-port trs)
(load-from-path (option 'test-name #f)))
(close-port log)
(close-port trs)
(close-port out))))
(exit 0)))
;;; Local Variables:
;;; eval: (add-hook 'write-file-functions 'time-stamp)
;;; time-stamp-start: "(define script-version \""
;;; time-stamp-format: "%:y-%02m-%02d.%02H"
;;; time-stamp-time-zone: "UTC"
;;; time-stamp-end: "\") ;UTC"
;;; End:
;;;; test-driver.scm ends here.

View File

@ -596,12 +596,18 @@ It is also possible to run a subset of the tests by defining the
make check TESTS="tests/store.scm tests/cpio.scm" make check TESTS="tests/store.scm tests/cpio.scm"
@end example @end example
By default, tests results are displayed at a file level. In order to
see the details of every individual test cases, it is possible to define
the @code{SCM_LOG_DRIVER_FLAGS} makefile variable as in this example:
@example
make check TESTS="tests/base64.scm" SCM_LOG_DRIVER_FLAGS="--brief=no"
@end example
Upon failure, please email @email{bug-guix@@gnu.org} and attach the Upon failure, please email @email{bug-guix@@gnu.org} and attach the
@file{test-suite.log} file. When @file{tests/@var{something}.scm} @file{test-suite.log} file. Please specify the Guix version being used
fails, please also attach the @file{@var{something}.log} file available as well as version numbers of the dependencies (@pxref{Requirements}) in
in the top-level build directory. Please specify the Guix version being your message.
used as well as version numbers of the dependencies
(@pxref{Requirements}) in your message.
@node Setting Up the Daemon @node Setting Up the Daemon
@section Setting Up the Daemon @section Setting Up the Daemon

View File

@ -31,6 +31,10 @@ unset CDPATH
if [ -x "@abs_top_builddir@/guix-daemon" ] if [ -x "@abs_top_builddir@/guix-daemon" ]
then then
# Silence the daemon's output, which is often useless, as well as that of
# Bash (such as "Terminated" messages when 'guix-daemon' is killed.)
exec 2> /dev/null
NIX_STORE_DIR="@GUIX_TEST_ROOT@/store" NIX_STORE_DIR="@GUIX_TEST_ROOT@/store"
# Do that because store.scm calls `canonicalize-path' on it. # Do that because store.scm calls `canonicalize-path' on it.

View File

@ -101,6 +101,3 @@
l)))) l))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -141,6 +141,3 @@
(equal? str "hello world\n"))))) (equal? str "hello world\n")))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -113,6 +113,3 @@
(file-exists? (string-append out "/bin/hello"))))) (file-exists? (string-append out "/bin/hello")))))
(test-end "builders") (test-end "builders")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -106,9 +106,6 @@
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'with-derivation-narinfo* 'scheme-indent-function 2) ;;; eval: (put 'with-derivation-narinfo* 'scheme-indent-function 2)
;;; End: ;;; End:

View File

@ -26,14 +26,14 @@
(define (assert-exit x) (define (assert-exit x)
(primitive-exit (if x 0 1))) (primitive-exit (if x 0 1)))
(test-begin "containers")
;; Skip these tests unless user namespaces are available and the setgroups ;; Skip these tests unless user namespaces are available and the setgroups
;; file (introduced in Linux 3.19 to address a security issue) exists. ;; file (introduced in Linux 3.19 to address a security issue) exists.
(unless (and (user-namespace-supported?) (unless (and (user-namespace-supported?)
(unprivileged-user-namespace-supported?) (unprivileged-user-namespace-supported?)
(setgroups-supported?)) (setgroups-supported?))
(exit 77)) (test-skip 7))
(test-begin "containers")
(test-assert "call-with-container, exit with 0 when there is no error" (test-assert "call-with-container, exit with 0 when there is no error"
(zero? (zero?
@ -142,6 +142,3 @@
(zero? result))))))) (zero? result)))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -98,6 +98,3 @@
(pk 'fail x #f))))) (pk 'fail x #f)))))
(test-end "cpan") (test-end "cpan")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -79,6 +79,3 @@
(stat:size (stat file)))))))))))))) (stat:size (stat file))))))))))))))
(test-end "cpio") (test-end "cpio")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -131,6 +131,3 @@ lines. And: this line continues the description.")
(pk 'fail x #f)))))) (pk 'fail x #f))))))
(test-end "cran") (test-end "cran")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -64,6 +64,3 @@
(lookup "openoffice.org" "2.3.0")))) (lookup "openoffice.org" "2.3.0"))))
(test-end "cve") (test-end "cve")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -1008,6 +1008,3 @@
(call-with-input-file out get-string-all)))) (call-with-input-file out get-string-all))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -104,6 +104,3 @@ information about package NAME. (Function 'elpa-package-info'.)"
(eval-test-with-elpa "auctex")) (eval-test-with-elpa "auctex"))
(test-end "elpa") (test-end "elpa")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -51,6 +51,3 @@
(equal? form '(uuid "foobar")))))) (equal? form '(uuid "foobar"))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -77,6 +77,3 @@
(pk 'fail x #f))))) (pk 'fail x #f)))))
(test-end "gem") (test-end "gem")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -784,9 +784,6 @@
(test-end "gexp") (test-end "gexp")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;; Local Variables: ;; Local Variables:
;; eval: (put 'test-assertm 'scheme-indent-function 1) ;; eval: (put 'test-assertm 'scheme-indent-function 1)
;; End: ;; End:

View File

@ -39,6 +39,3 @@
("gnutls" "gnutls-3.2.18-w32.zip"))))) ("gnutls" "gnutls-3.2.18-w32.zip")))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -159,6 +159,3 @@
(string=? (readlink two) one)))))) (string=? (readlink two) one))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -276,6 +276,3 @@ edges."
(list p1a p1b p0))))))) (list p1a p1b p0)))))))
(test-end "graph") (test-end "graph")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -64,6 +64,3 @@
"ORIGIN/foo"))) "ORIGIN/foo")))
(test-end "gremlin") (test-end "gremlin")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -160,6 +160,3 @@ library
(x (pk 'fail x #f)))) (x (pk 'fail x #f))))
(test-end "hackage") (test-end "hackage")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -126,6 +126,3 @@ In Guile <= 2.0.9, CBIPs were always fully buffered, so the
(list hello hash world)))) (list hello hash world))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -34,6 +34,3 @@
(beautify-description "A function to establish world peace")) (beautify-description "A function to establish world peace"))
(test-end "import-utils") (test-end "import-utils")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -581,9 +581,6 @@ requests."
(test-end "lint") (test-end "lint")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;; Local Variables: ;; Local Variables:
;; eval: (put 'with-http-server 'scheme-indent-function 1) ;; eval: (put 'with-http-server 'scheme-indent-function 1)
;; eval: (put 'with-warnings 'scheme-indent-function 0) ;; eval: (put 'with-warnings 'scheme-indent-function 0)

View File

@ -258,6 +258,3 @@
'()))) '())))
(test-end "monads") (test-end "monads")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -320,9 +320,6 @@
(test-end "nar") (test-end "nar")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'with-file-tree 'scheme-indent-function 2) ;;; eval: (put 'with-file-tree 'scheme-indent-function 2)
;;; End: ;;; End:

View File

@ -799,9 +799,6 @@
(test-end "packages") (test-end "packages")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'dummy-package 'scheme-indent-function 1) ;;; eval: (put 'dummy-package 'scheme-indent-function 1)
;;; End: ;;; End:

View File

@ -287,6 +287,3 @@
(canonical-sexp->sexp (sexp->canonical-sexp sexp)))) (canonical-sexp->sexp (sexp->canonical-sexp sexp))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -119,6 +119,3 @@
(corrupt-signature 'c)))) (corrupt-signature 'c))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -320,9 +320,6 @@
(test-end "profiles") (test-end "profiles")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'dummy-package 'scheme-indent-function 1) ;;; eval: (put 'dummy-package 'scheme-indent-function 1)
;;; End: ;;; End:

View File

@ -121,6 +121,3 @@ References: ~a~%"
(response-code (http-get (publish-uri (string-append "/nar/invalid")))))) (response-code (http-get (publish-uri (string-append "/nar/invalid"))))))
(test-end "publish") (test-end "publish")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -106,6 +106,3 @@ baz > 13.37")
(pk 'fail x #f))))) (pk 'fail x #f)))))
(test-end "pypi") (test-end "pypi")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -305,6 +305,3 @@ Description: 1st line,
'("a"))) '("a")))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -103,6 +103,3 @@
(eq? dep findutils))))))))))) (eq? dep findutils)))))))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -64,9 +64,6 @@
(test-end "scripts") (test-end "scripts")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'with-environment-variable 'scheme-indent-function 2) ;;; eval: (put 'with-environment-variable 'scheme-indent-function 2)
;;; End: ;;; End:

View File

@ -119,6 +119,3 @@
(null? (e s3))))) (null? (e s3)))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -47,6 +47,3 @@
(set-contains? s3 b)))) (set-contains? s3 b))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -88,9 +88,6 @@
(test-end "size") (test-end "size")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'match* 'scheme-indent-function 1) ;;; eval: (put 'match* 'scheme-indent-function 1)
;;; End: ;;; End:

View File

@ -71,6 +71,3 @@
(pk 'fail x #f)))) (pk 'fail x #f))))
(test-end "snix") (test-end "snix")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -911,6 +911,3 @@
(path-info-deriver (query-path-info %store o)))))) (path-info-deriver (query-path-info %store o))))))
(test-end "store") (test-end "store")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -275,9 +275,6 @@ a file for NARINFO."
(test-end "substitute") (test-end "substitute")
(exit (= (test-runner-fail-count (test-runner-current)) 0))
;;; Local Variables: ;;; Local Variables:
;;; eval: (put 'with-narinfo 'scheme-indent-function 1) ;;; eval: (put 'with-narinfo 'scheme-indent-function 1)
;;; eval: (put 'test-quit 'scheme-indent-function 2) ;;; eval: (put 'test-quit 'scheme-indent-function 2)

View File

@ -245,6 +245,3 @@
(lo (interface-address lo))))))) (lo (interface-address lo)))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -72,6 +72,3 @@
(eq? gnu (operating-system-store-file-system os)))) (eq? gnu (operating-system-store-file-system os))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -250,6 +250,3 @@ Second line" 24))
(show-manifest-transaction store m t))))))))) (show-manifest-transaction store m t)))))))))
(test-end "ui") (test-end "ui")
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -125,6 +125,3 @@
(eq? 'directory (stat:type (lstat "bin")))))))) (eq? 'directory (stat:type (lstat "bin"))))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -44,6 +44,3 @@
'("ftp://example.org/foo-1.tar.xz.sig")))))) '("ftp://example.org/foo-1.tar.xz.sig"))))))
(test-end) (test-end)
(exit (= (test-runner-fail-count (test-runner-current)) 0))

View File

@ -336,6 +336,3 @@
(test-end) (test-end)
(false-if-exception (delete-file temp-file)) (false-if-exception (delete-file temp-file))
(exit (= (test-runner-fail-count (test-runner-current)) 0))