me/guix
Archived
1
0
Fork 0
Code Activity

gnu-maintenance: 'generic-html' updater ignores invalid host names.

Browse source 
Previously "guix refresh xkbset" for example would crash with a
getaddrinfo-error because the domain name is invalid.  Now it reports
failure to update.

Reported by Tyler Wolf <tyler@twolf.io>
in <https://issues.guix.gnu.org/59598>.

* guix/gnu-maintenance.scm (latest-html-updatable-release): Return #f
upon 'getaddrinfo-error' as well.
This commit is contained in:
Ludovic Courtès 2022-12-08 12:03:00 +01:00
parent fc774ece91
commit c370998f01
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
guix/gnu-maintenance.scm
View file

@ -1,5 +1,5 @@
;;; GNU Guix --- Functional package management for GNU ;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2010-2022 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2012, 2013 Nikita Karetnikov <nikita@karetnikov.org> ;;; Copyright © 2012, 2013 Nikita Karetnikov <nikita@karetnikov.org>
;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com> ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
;;; Copyright © 2022 Maxime Devos <maximedevos@telenet.be> ;;; Copyright © 2022 Maxime Devos <maximedevos@telenet.be>
@ -837,7 +837,7 @@ the directory containing its source tarball."
;; Return false and move on upon connection failures and bogus HTTP ;; Return false and move on upon connection failures and bogus HTTP
;; servers. ;; servers.
(unless (memq key '(gnutls-error tls-certificate-error (unless (memq key '(gnutls-error tls-certificate-error
system-error system-error getaddrinfo-error
bad-header bad-header-component)) bad-header bad-header-component))
(apply throw key args)) (apply throw key args))
#f)))) #f))))