me/guix
Archived
1
0
Fork 0
Code Activity

Revert "lint: Append "/info/refs" to git-reference-url."

Browse source 
This reverts commit c9af27d4ca.

The change causes 'guix lint' to print URI not reachable (403) errors for
GitHub every URLs.
This commit is contained in:
Maxim Cournoyer 2023-03-28 21:18:27 -04:00
parent d2aa65fc67
commit cc7a79a8ad
No known key found for this signature in database
GPG key ID: 1260E46482E63562
2 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
guix/lint.scm
View file

@ -1224,14 +1224,7 @@ password, provided REF's URI is HTTP or HTTPS."
'()))) '())))
((git-reference? (origin-uri origin)) ((git-reference? (origin-uri origin))
(warnings-for-uris (warnings-for-uris
;; for atftp, lint produced a warning: (list (string->uri (git-reference-url (origin-uri origin))))))
;; gnu/packages/networking.scm:2924:5: atftp@0.8.0:
;; URI https://git.code.sf.net/p/atftp/code not reachable:
;; 404 ("Not Found")
;; fix from here: https://issues.guix.gnu.org/62156#3
(list (string->uri (string-append
(git-reference-url (origin-uri origin))
"/info/refs")))))
((or (svn-reference? (origin-uri origin)) ((or (svn-reference? (origin-uri origin))
(svn-multi-reference? (origin-uri origin))) (svn-multi-reference? (origin-uri origin)))
(let ((uri (svn-reference-uri-with-userinfo (origin-uri origin)))) (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))

2
tests/lint.scm
View file

@ -1052,7 +1052,7 @@
(parameterize ((%http-server-port 0)) (parameterize ((%http-server-port 0))
(with-http-server `((,redirect "")) (with-http-server `((,redirect ""))
(test-equal "source, git-reference: 301 -> 200" (test-equal "source, git-reference: 301 -> 200"
(format #f "permanent redirect from ~a/info/refs to ~a" (format #f "permanent redirect from ~a to ~a"
(%local-url) initial-url) (%local-url) initial-url)
(let ((pkg (dummy-package (let ((pkg (dummy-package
"x" "x"