me/guix
Archived
1
0
Fork 0
Code Activity

gnu: modifying make-chromium-extension to rely on node-crx3.

Browse source 
* gnu/build/chromium-extension.scm (make-crx): Lift Xorg and Chromium
dependencies, rely on node-crx3 instead.

Signed-off-by: Marius Bakke <marius@gnu.org>
This commit is contained in:
Nicolas Graves 2022-07-20 12:39:34 +02:00 • committed by Marius Bakke
parent 1b323c58c8
commit cda3de3b7d
No known key found for this signature in database
GPG key ID: A2A06DF2A33A54FA
1 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
gnu/build/chromium-extension.scm
View file

@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU ;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2020, 2021 Marius Bakke <marius@gnu.org> ;;; Copyright © 2020, 2021 Marius Bakke <marius@gnu.org>
;;; Copyright © 2022 Nicolas Graves <ngraves@ngraves.fr>
;;; ;;;
;;; This file is part of GNU Guix. ;;; This file is part of GNU Guix.
;;; ;;;
@ -19,10 +20,9 @@
(define-module (gnu build chromium-extension) (define-module (gnu build chromium-extension)
#:use-module (guix gexp) #:use-module (guix gexp)
#:use-module (guix packages) #:use-module (guix packages)
#:use-module (gnu packages chromium)
#:use-module (gnu packages gnupg) #:use-module (gnu packages gnupg)
#:use-module (gnu packages tls) #:use-module (gnu packages tls)
#:use-module (gnu packages xorg) #:use-module (gnu packages node-xyz)
#:use-module (guix build-system trivial) #:use-module (guix build-system trivial)
#:export (make-chromium-extension)) #:export (make-chromium-extension))
@ -69,24 +69,14 @@ in PACKAGE-OUTPUT of PACKAGE. The extension will be signed with SIGNING-KEY."
(string-append name "-" version ".crx") (string-append name "-" version ".crx")
(with-imported-modules '((guix build utils)) (with-imported-modules '((guix build utils))
#~(begin #~(begin
;; This is not great. We pull Xorg and Chromium just to Zip and
;; sign an extension. This should be implemented with something
;; lighter. (TODO: where is the CRXv3 documentation..?)
(use-modules (guix build utils)) (use-modules (guix build utils))
(let ((chromium #$(file-append ungoogled-chromium "/bin/chromium")) (let ((crx3 #+(file-append node-crx3 "/bin/crx3"))
(xvfb #$(file-append xorg-server "/bin/Xvfb"))
(packdir (string-append (getcwd) "/extension"))) (packdir (string-append (getcwd) "/extension")))
(mkdir packdir) (mkdir packdir)
(copy-recursively (ungexp package package-output) packdir (copy-recursively (ungexp package package-output) packdir
;; Ensure consistent file modification times. ;; Ensure consistent file modification times.
#:keep-mtime? #t) #:keep-mtime? #t)
(system (string-append xvfb " :1 &")) (invoke crx3 "--keyPath" #$signing-key packdir)
(setenv "DISPLAY" ":1")
(sleep 2) ;give Xorg some time to initialize...
(invoke chromium
"--user-data-dir=chromium-profile"
(string-append "--pack-extension=" packdir)
(string-append "--pack-extension-key=" #$signing-key))
(copy-file (string-append packdir ".crx") #$output)))) (copy-file (string-append packdir ".crx") #$output))))
#:local-build? #t)) #:local-build? #t))