gnu: kakoune: Update to 2018.04.13.

* gnu/packages/text-editors.scm (kakoune): Update to 2018.04.13.
Remove LET binding for the git revision and re-indent accordingly.
[version, source]: Replace the git checkout with new release tarball.
[arguments]: Remove ‘fix-test-permissions’ phase.
[native-inputs]: Add PKG-CONFIG.

gnu/packages/text-editors.scm

@@ -100,59 +100,55 @@ based command language.")
                    license:expat))))         ; lexers and libutf.[ch]
 
 (define-public kakoune
-  (let ((commit "125c8b7e80995732e0d8c87b82040025748f1b4f")
+  (package
-        (revision "1"))
+    (name "kakoune")
-    (package
+    (version "2018.04.13")
-      (name "kakoune")
+    (source
-      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
+     (origin
-      (source
+       (method url-fetch)
-       (origin
+       (uri (string-append "https://github.com/mawww/kakoune/"
-         (file-name (string-append "kakoune-" version "-checkout"))
+                           "releases/download/v" version "/"
-         (method git-fetch)
+                           name "-" version ".tar.bz2"))
-         (uri (git-reference
+       (sha256
-               (url "https://github.com/mawww/kakoune.git")
+        (base32
-               (commit commit)))
+         "1kkzs5nrjxzd1jq7a4k7qfb5kg05871z0r3d9c0yhz9shf6wz36d"))))
-         (sha256
+    (build-system gnu-build-system)
-          (base32
+    (arguments
-           "19qs99l8r9p1vi5pxxx9an22fvi7xx40qw3jh2cnh2mbacawvdyb"))))
+     `(#:make-flags
-      (build-system gnu-build-system)
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
-      (arguments
+       #:phases
-       `(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       (modify-phases %standard-phases
-         #:phases
+         (add-after 'unpack 'patch-source
-         (modify-phases %standard-phases
+           (lambda _
-           (add-after 'unpack 'patch-source
+             ;; kakoune uses confstr with _CS_PATH to find out where to find
-             (lambda _
+             ;; a posix shell, but this doesn't work in the build
-               ;; kakoune uses confstr with _CS_PATH to find out where to find
+             ;; environment. This substitution just replaces that result
-               ;; a posix shell, but this doesn't work in the build
+             ;; with the "sh" path.
-               ;; environment. This substitution just replaces that result
+             (substitute* "src/shell_manager.cc"
-               ;; with the "sh" path.
+               (("if \\(m_shell.empty\\(\\)\\)" line)
-               (substitute* "src/shell_manager.cc"
+                (string-append "m_shell = \"" (which "sh")
-                 (("if \\(m_shell.empty\\(\\)\\)" line)
+                               "\";\n        " line)))
-                  (string-append "m_shell = \"" (which "sh")
+             #t))
-                                 "\";\n        " line)))
+         (delete 'configure)            ; no configure script
-               #t))
+         ;; kakoune requires us to be in the src/ directory to build
-           (delete 'configure)
+         (add-before 'build 'chdir
-           ;; kakoune requires us to be in the src/ directory to build
+           (lambda _ (chdir "src") #t)))))
-           (add-before 'build 'chdir
+    (native-inputs
-             (lambda _ (chdir "src") #t))
+     `(("asciidoc" ,asciidoc)
-           (add-before 'check 'fix-test-permissions
+       ("pkg-config" ,pkg-config)
-             (lambda _
+       ("ruby" ,ruby)))
-               ;; Out git downloader doesn't give us write permissions, but
+    (inputs
-               ;; without them the tests fail.
+     `(("ncurses" ,ncurses)
-               (zero? (system* "chmod" "-R" "u+w" "../test")))))))
+       ("boost" ,boost)))
-      (native-inputs `(("asciidoc" ,asciidoc)
+    (synopsis "Vim-inspired code editor")
-                       ("ruby" ,ruby)))
+    (description
-      (inputs `(("ncurses" ,ncurses)
+     "Kakoune is a code editor heavily inspired by Vim, as such most of its
-                ("boost" ,boost)))
-      (synopsis "Vim-inspired code editor")
-      (description
-       "Kakoune is a code editor heavily inspired by Vim, as such most of its
 commands are similar to Vi's ones, and it shares Vi's \"keystrokes as a text
 editing language\" model.  Kakoune has a strong focus on interactivity, most
 commands provide immediate and incremental results, while still being
 competitive (as in keystroke count) with Vim.")
-      (home-page "http://kakoune.org/")
+    (home-page "http://kakoune.org/")
-      (license license:unlicense))))
+    (license license:unlicense)))
 
 (define-public joe
   (package