Patches should fix all CVEs reported by `guix lint`: CVE-2015-7747; CVE-2017-6827, CVE-2017-6828, CVE-2017-6829, CVE-2017-6830, CVE-2017-6831, CVE-2017-6832, CVE-2017-6833, CVE-2017-6834, CVE-2017-6835, CVE-2017-6836, CVE-2017-6837, CVE-2017-6838, CVE-2017-6839; CVE-2018-13440; CVE-2018-17095 Since the patches do not reference to CVEs, it's a bit hard to tell which patch actually closes which CVE. Debian reports all these to be closed by the patches below and NixPkgs provides references. * gnu/packages/audio.scm (audiofile): New variable. * gnu/packages/patches/audiofile-fix-datatypes-in-tests.patch, gnu/packages/patches/audiofile-fix-sign-conversion.patch, gnu/packages/patches/audiofile-CVE-2015-7747.patch, gnu/packages/patches/audiofile-CVE-2018-13440.patch, gnu/packages/patches/audiofile-CVE-2018-17095.patch, gnu/packages/patches/audiofile-Check-the-number-of-coefficients.patch, gnu/packages/patches/audiofile-Fail-on-error-in-parseFormat.patch, gnu/packages/patches/audiofile-Fix-index-overflow-in-IMA.cpp.patch, gnu/packages/patches/audiofile-Fix-multiply-overflow-sfconvert.patch, gnu/packages/patches/audiofile-Fix-overflow-in-MSADPCM-decodeSam.patch, gnu/packages/patches/audiofile-division-by-zero-BlockCodec-runPull.patch, gnu/packages/patches/audiofile-hurd.patch, gnu/packages/patches/audiofile-signature-of-multiplyCheckOverflow.patch: New files. * gnu/local.mk: Add them.
		
			
				
	
	
		
			28 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			28 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From fde6d79fb8363c4a329a184ef0b107156602b225 Mon Sep 17 00:00:00 2001
 | 
						|
From: Wim Taymans <wtaymans@redhat.com>
 | 
						|
Date: Thu, 27 Sep 2018 10:48:45 +0200
 | 
						|
Subject: [PATCH] ModuleState: handle compress/decompress init failure
 | 
						|
 | 
						|
When the unit initcompress or initdecompress function fails,
 | 
						|
m_fileModule is NULL. Return AF_FAIL in that case instead of
 | 
						|
causing NULL pointer dereferences later.
 | 
						|
 | 
						|
Fixes #49
 | 
						|
---
 | 
						|
 libaudiofile/modules/ModuleState.cpp | 3 +++
 | 
						|
 1 file changed, 3 insertions(+)
 | 
						|
 | 
						|
diff --git a/libaudiofile/modules/ModuleState.cpp b/libaudiofile/modules/ModuleState.cpp
 | 
						|
index 0c29d7a..070fd9b 100644
 | 
						|
--- a/libaudiofile/modules/ModuleState.cpp
 | 
						|
+++ b/libaudiofile/modules/ModuleState.cpp
 | 
						|
@@ -75,6 +75,9 @@ status ModuleState::initFileModule(AFfilehandle file, Track *track)
 | 
						|
 		m_fileModule = unit->initcompress(track, file->m_fh, file->m_seekok,
 | 
						|
 			file->m_fileFormat == AF_FILE_RAWDATA, &chunkFrames);
 | 
						|
 
 | 
						|
+	if (!m_fileModule)
 | 
						|
+		return AF_FAIL;
 | 
						|
+
 | 
						|
 	if (unit->needsRebuffer)
 | 
						|
 	{
 | 
						|
 		assert(unit->nativeSampleFormat == AF_SAMPFMT_TWOSCOMP);
 |