Non-exhaustively fixes CVE-2016-9844, CVE-2018-1000035, CVE-2018-18384, and CVE-2019-13232. * gnu/packages/patches/unzip-COVSCAN-fix-unterminated-string.patch, gnu/packages/patches/unzip-CVE-2016-9844.patch, gnu/packages/patches/unzip-CVE-2018-1000035.patch, gnu/packages/patches/unzip-CVE-2018-18384.patch, gnu/packages/patches/unzip-case-insensitive.patch, gnu/packages/patches/unzip-alt-iconv-utf8-print.patch, gnu/packages/patches/unzip-alt-iconv-utf8.patch, gnu/packages/patches/unzip-close.patch, gnu/packages/patches/unzip-exec-shield.patch, gnu/packages/patches/unzip-fix-recmatch.patch, gnu/packages/patches/unzip-manpage-fix.patch, gnu/packages/patches/unzip-overflow.patch, gnu/packages/patches/unzip-symlink.patch, gnu/packages/patches/unzip-timestamp.patch, gnu/packages/patches/unzip-valgrind.patch, gnu/packages/patches/unzip-x-option.patch, gnu/packages/patches/unzip-zipbomb-manpage.patch, gnu/packages/patches/unzip-zipbomb-part1.patch, gnu/packages/patches/unzip-zipbomb-part2.patch, gnu/packages/patches/unzip-zipbomb-part3.patch: New patches. * gnu/local.mk (dist_patch_DATA): Register them. * gnu/packages/compression.scm (unzip/fixed): New variable. Apply patches. (unzip)[replacement]: Graft.
		
			
				
	
	
		
			25 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			25 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
diff --git a/extract.c b/extract.c
 | 
						|
index a0a4929..9ef80b3 100644
 | 
						|
--- a/extract.c
 | 
						|
+++ b/extract.c
 | 
						|
@@ -2214,6 +2214,7 @@ static int test_compr_eb(__G__ eb, eb_size, compr_offset, test_uc_ebdata)
 | 
						|
     ulg eb_ucsize;
 | 
						|
     uch *eb_ucptr;
 | 
						|
     int r;
 | 
						|
+    ush method;
 | 
						|
 
 | 
						|
     if (compr_offset < 4)                /* field is not compressed: */
 | 
						|
         return PK_OK;                    /* do nothing and signal OK */
 | 
						|
@@ -2223,6 +2224,12 @@ static int test_compr_eb(__G__ eb, eb_size, compr_offset, test_uc_ebdata)
 | 
						|
          eb_size <= (compr_offset + EB_CMPRHEADLEN)))
 | 
						|
         return IZ_EF_TRUNC;               /* no compressed data! */
 | 
						|
 
 | 
						|
+    method = makeword(eb + (EB_HEADSIZE + compr_offset));
 | 
						|
+    if ((method == STORED) && (eb_size != compr_offset + EB_CMPRHEADLEN + eb_ucsize))
 | 
						|
+        return PK_ERR;            /* compressed & uncompressed
 | 
						|
+                                   * should match in STORED
 | 
						|
+                                   * method */
 | 
						|
+
 | 
						|
     if (
 | 
						|
 #ifdef INT_16BIT
 | 
						|
         (((ulg)(extent)eb_ucsize) != eb_ucsize) ||
 |