There was/is something funny going on with the bootstrap glibc. The symbol for posix_spawnp points to getopt_r. Which in turn leads to a lot of crashed in tests later on. I extended the glibc-bootstrap patch to work around this bug. * gnu/packages/patches/glibc-bootstrap-system.patch: Adjust patch to work correctly with new architectures. Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
		
			
				
	
	
		
			51 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			51 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
We want to allow builds in chroots that lack /bin/sh.  Thus, system(3)
 | 
						|
and popen(3) need to be tweaked to use the right shell.  For the bootstrap
 | 
						|
glibc, we just use whatever `sh' can be found in $PATH.  The final glibc
 | 
						|
instead uses the hard-coded absolute file name of `bash'.
 | 
						|
 | 
						|
--- a/sysdeps/posix/system.c
 | 
						|
+++ b/sysdeps/posix/system.c
 | 
						|
@@ -140,7 +140,7 @@ do_system (const char *line)
 | 
						|
   __posix_spawnattr_setflags (&spawn_attr,
 | 
						|
 			      POSIX_SPAWN_SETSIGDEF | POSIX_SPAWN_SETSIGMASK);
 | 
						|
 
 | 
						|
-  status = __posix_spawn (&pid, SHELL_PATH, 0, &spawn_attr,
 | 
						|
+  status = __posix_spawnp (&pid, SHELL_NAME, 0, &spawn_attr,
 | 
						|
 			  (char *const[]){ (char*) SHELL_NAME,
 | 
						|
 					   (char*) "-c",
 | 
						|
 					   (char *) line, NULL },
 | 
						|
--- a/libio/iopopen.c
 | 
						|
+++ b/libio/iopopen.c
 | 
						|
@@ -85,7 +85,7 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command,
 | 
						|
 	return false;
 | 
						|
     }
 | 
						|
 
 | 
						|
-  if (__posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0,
 | 
						|
+  if (__posix_spawnp (&((_IO_proc_file *) fp)->pid, "sh", fa, 0,
 | 
						|
 		     (char *const[]){ (char*) "sh", (char*) "-c",
 | 
						|
 		     (char *) command, NULL }, __environ) != 0)
 | 
						|
     return false;
 | 
						|
 | 
						|
--- a/include/spawn.h
 | 
						|
+++ b/include/spawn.h
 | 
						|
@@ -5,6 +5,9 @@
 | 
						|
 __typeof (posix_spawn) __posix_spawn;
 | 
						|
 libc_hidden_proto (__posix_spawn)
 | 
						|
 | 
						|
+__typeof (posix_spawnp) __posix_spawnp;
 | 
						|
+libc_hidden_proto (__posix_spawnp)
 | 
						|
+
 | 
						|
 __typeof (posix_spawn_file_actions_addclose)
 | 
						|
   __posix_spawn_file_actions_addclose attribute_hidden;
 | 
						|
 | 
						|
--- a/posix/spawnp.c
 | 
						|
+++ b/posix/spawnp.c
 | 
						|
@@ -31,6 +31,7 @@ __posix_spawnp (pid_t *pid, const char *file,
 | 
						|
                   SPAWN_XFLAGS_USE_PATH);
 | 
						|
 }
 | 
						|
 versioned_symbol (libc, __posix_spawnp, posix_spawnp, GLIBC_2_15);
 | 
						|
+libc_hidden_def (__posix_spawnp)
 | 
						|
 | 
						|
 | 
						|
 #if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_15)
 | 
						|
 |